New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinit crypto before calling RSA.generate when generating keys. #30238

Merged
merged 1 commit into from Jan 13, 2016

Conversation

Projects
None yet
2 participants
@rallytime
Contributor

rallytime commented Jan 8, 2016

Fixes #28396

In order for the -P argument to work with salt-cloud, we need to
make sure we're re-initing crypto before calling RSA.generate. This
is similar to the fixes in #23825.

Reinit crypto before calling RSA.generate when generating keys.
Fixes #28396

In order for the `-P` argument to work with salt-cloud, we need to
make sure we're re-initing crypto before calling RSA.generate. This
is similar to the fixes in #23825.
@rallytime

This comment has been minimized.

Show comment
Hide comment
@rallytime

rallytime Jan 13, 2016

Contributor

These test failures appear to be the same ones occurring on the 2015.8 branch currently.

Contributor

rallytime commented Jan 13, 2016

These test failures appear to be the same ones occurring on the 2015.8 branch currently.

@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Jan 13, 2016

Contributor

This has been reviewed and signed-off on by me (@cachedout) and by @thatch45 .

Contributor

cachedout commented Jan 13, 2016

This has been reviewed and signed-off on by me (@cachedout) and by @thatch45 .

cachedout added a commit that referenced this pull request Jan 13, 2016

Merge pull request #30238 from rallytime/fix-28396
Reinit crypto before calling RSA.generate when generating keys.

@cachedout cachedout merged commit 5a8da62 into saltstack:2015.8 Jan 13, 2016

2 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #11263 — FAILURE
Details
jenkins/salt-pr-rs-ubuntu14.04-n Salt PR - RS Ubuntu 14 #8753 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12672 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #12371 — SUCCESS
Details
@rallytime

This comment has been minimized.

Show comment
Hide comment
@rallytime

rallytime Jan 13, 2016

Contributor

Thanks guys!

Contributor

rallytime commented Jan 13, 2016

Thanks guys!

@rallytime rallytime deleted the rallytime:fix-28396 branch Jan 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment