Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixes performance and timeout issues on win_pkg.install #30249
Whenever there are no changes in the registry, win_pkg.install will check for any difference applied to it 1001 times before giving up, this causes an unnecessary CPU spike that may lead to performance degradation on the host or in any of its running applications, and if the host it's an AWS burstable instance this may cause unnecessary CPU credit consumption.
This commit changes that behaviour: the module will now check for any difference in the registry for a maximum of 10 times with an interval of 3 seconds before giving up.