New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RPM issues with the date/time and add package attributes filtering #30267

Merged
merged 24 commits into from Jan 14, 2016

Conversation

Projects
None yet
3 participants
@isbm
Contributor

isbm commented Jan 11, 2016

Date/time issues: date/time was returned only in the ISO format. Now it is returned in ISO and Unix format.

Attributes filtering: Information about installed package was overwhelming. Now it is possible to narrow down to only those attributes that are necessary to view. For example:

salt '*' pkg.info_installed vim attr=url,build_date,release,arch

Documentation is updated accordingly.

Show outdated Hide outdated salt/modules/rpm.py Outdated
Show outdated Hide outdated salt/modules/rpm.py Outdated
Show outdated Hide outdated salt/modules/rpm.py Outdated
@isbm

This comment has been minimized.

Show comment
Hide comment
@isbm

isbm Jan 13, 2016

Contributor

@kkaempf query is now constructed dynamically.

Contributor

isbm commented Jan 13, 2016

@kkaempf query is now constructed dynamically.

Show outdated Hide outdated salt/modules/rpm.py Outdated
"-----\n'"),
output_loglevel='trace', env={'LC_ALL': 'en_US', 'TZ': 'UTC'}, clean_env=True)
# Construct query format
attr_map = {

This comment has been minimized.

@kkaempf

kkaempf Jan 13, 2016

Contributor

I very much like the ability to ask for {build,install}_date vs {build,install}_date_time_t you had before.

@kkaempf

kkaempf Jan 13, 2016

Contributor

I very much like the ability to ask for {build,install}_date vs {build,install}_date_time_t you had before.

This comment has been minimized.

@isbm

isbm Jan 13, 2016

Contributor

Back.

@isbm

isbm Jan 13, 2016

Contributor

Back.

Show outdated Hide outdated salt/modules/rpm.py Outdated

cachedout added a commit that referenced this pull request Jan 14, 2016

Merge pull request #30267 from isbm/isbm-zypper-isotimefix
Fix RPM issues with the date/time and add package attributes filtering

@cachedout cachedout merged commit f4118be into saltstack:2015.8 Jan 14, 2016

2 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #11282 — FAILURE
Details
jenkins/salt-pr-rs-ubuntu14.04-n Salt PR - RS Ubuntu 14 #8772 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12691 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #12390 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment