New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permanent argument in firewalld. #30275

Merged
merged 1 commit into from Jan 13, 2016

Conversation

Projects
None yet
2 participants
@abednarik
Contributor

abednarik commented Jan 11, 2016

As described in #30240 there are some inconsistency between ports and services.

This is just a partial fix. See the linked issue, that are a few more things to do that will make this module better.

Add permanent argument in firewalld.
As described in #30240 there are some inconsistency between ports and services.
@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Jan 13, 2016

Contributor

This seems like a reasonable change, but will modify states for people who upgrade Salt. Let's make sure this is noted in the release notes. cc: @jacobhammons

Contributor

cachedout commented Jan 13, 2016

This seems like a reasonable change, but will modify states for people who upgrade Salt. Let's make sure this is noted in the release notes. cc: @jacobhammons

cachedout added a commit that referenced this pull request Jan 13, 2016

@cachedout cachedout merged commit ea60767 into saltstack:2015.8 Jan 13, 2016

2 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #11203 — FAILURE
Details
jenkins/salt-pr-rs-ubuntu14.04-n Salt PR - RS Ubuntu 14 #8695 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12614 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #12313 — SUCCESS
Details

@abednarik abednarik deleted the abednarik:fix_firewalld_ports_permanent branch Jan 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment