New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipset: fix test=true & add comment for every entry #30292

Merged
merged 1 commit into from Jan 13, 2016

Conversation

Projects
None yet
2 participants
@thegoodduke

thegoodduke commented Jan 12, 2016

for #30170 commit in 2015.8, again.

@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Jan 12, 2016

Contributor

@thegoodduke Could you take a look at the lint errors? There may be a typo in here.

Contributor

cachedout commented Jan 12, 2016

@thegoodduke Could you take a look at the lint errors? There may be a typo in here.

@thegoodduke

This comment has been minimized.

Show comment
Hide comment
@thegoodduke

thegoodduke Jan 13, 2016

thanks, have fixed it.

thegoodduke commented Jan 13, 2016

thanks, have fixed it.

cachedout added a commit that referenced this pull request Jan 13, 2016

Merge pull request #30292 from thegoodduke/fix_ipset
ipset: fix test=true & add comment for every entry

@cachedout cachedout merged commit 8706720 into saltstack:2015.8 Jan 13, 2016

2 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #11270 — FAILURE
Details
jenkins/salt-pr-rs-ubuntu14.04-n Salt PR - RS Ubuntu 14 #8760 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12679 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #12378 — SUCCESS
Details
@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Jan 13, 2016

Contributor

Thanks, @thegoodduke

Contributor

cachedout commented Jan 13, 2016

Thanks, @thegoodduke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment