New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent orphaned volumes #30346

Merged
merged 1 commit into from Jan 14, 2016

Conversation

Projects
None yet
4 participants
@pass-by-value
Contributor

pass-by-value commented Jan 13, 2016

No description provided.

cachedout added a commit that referenced this pull request Jan 14, 2016

@cachedout cachedout merged commit af2ddfd into saltstack:2015.8 Jan 14, 2016

2 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #11300 — FAILURE
Details
jenkins/salt-pr-rs-ubuntu14.04-n Salt PR - RS Ubuntu 14 #8790 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12711 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #12409 — SUCCESS
Details
instance_id))
# Instance isn't running yet, so cannot attach this volume to it
# wait for instance to run and try again
time.sleep(10)

This comment has been minimized.

@DanyC97

DanyC97 Jan 15, 2016

@pass-by-value boto (100% sure on v3 not sure on v2) does have

waiter = self._client.get_waiter('instance_running')
                waiter.wait(InstanceIds=[nat[0].id])

instead of using a hardcoded 10 sec value. My $0.02 cents

@DanyC97

DanyC97 Jan 15, 2016

@pass-by-value boto (100% sure on v3 not sure on v2) does have

waiter = self._client.get_waiter('instance_running')
                waiter.wait(InstanceIds=[nat[0].id])

instead of using a hardcoded 10 sec value. My $0.02 cents

This comment has been minimized.

@techhat

techhat Jan 15, 2016

Member

This comment has been minimized.

@pass-by-value

pass-by-value Jan 15, 2016

Contributor

Thanks @DanyC97 and @techhat. I'll update this.

@pass-by-value

pass-by-value Jan 15, 2016

Contributor

Thanks @DanyC97 and @techhat. I'll update this.

@pass-by-value

This comment has been minimized.

Show comment
Hide comment
@pass-by-value

pass-by-value Jan 15, 2016

Contributor

#30396 should remove the hardcoded value @DanyC97 and @techhat

@DanyC97 fyi: I'm using the wait_for_ip from utils because the ec2 driver doesn't use make use of boto. Do let me know what you think.

Contributor

pass-by-value commented Jan 15, 2016

#30396 should remove the hardcoded value @DanyC97 and @techhat

@DanyC97 fyi: I'm using the wait_for_ip from utils because the ec2 driver doesn't use make use of boto. Do let me know what you think.

@DanyC97

This comment has been minimized.

Show comment
Hide comment
@DanyC97

DanyC97 Jan 16, 2016

@pass-by-value +1 Ideally ec2 driver should rely on boto but that is for a different time, thanks

DanyC97 commented Jan 16, 2016

@pass-by-value +1 Ideally ec2 driver should rely on boto but that is for a different time, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment