New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back-port #30347 to 2015.8 #30349

Merged
merged 2 commits into from Jan 14, 2016

Conversation

Projects
None yet
4 participants
@rallytime
Contributor

rallytime commented Jan 13, 2016

Back-port #30347 to 2015.8

cachedout added a commit that referenced this pull request Jan 14, 2016

@cachedout cachedout merged commit bccb8f3 into saltstack:2015.8 Jan 14, 2016

2 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #11308 — FAILURE
Details
jenkins/salt-pr-rs-ubuntu14.04-n Salt PR - RS Ubuntu 14 #8797 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12719 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #12415 — SUCCESS
Details

@rallytime rallytime deleted the rallytime:bp-30347 branch Jan 14, 2016

@steverweber

This comment has been minimized.

Show comment
Hide comment
@steverweber

steverweber Feb 16, 2016

Contributor

I think raise SaltSystemExit(err_msg) causes issues.
this might be fine when using salt-cloud... however users like myself use states.

When using highstate or salt-call the other states should continue...

salt-call state.apply example.cloud.vms
got stuck after SaltSystemExit...

[DEBUG   ] LazyLoaded rackspace.list_locations
[DEBUG   ] [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:765)
[DEBUG   ] Failed to execute 'vmware.list_nodes_min()' while querying for running nodes: Could not connect to the specified vCenter server. Please check the debug log for more information
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/salt/cloud/__init__.py", line 2269, in run_parallel_map_providers_query
    cloud.clouds[data['fun']]()
  File "/usr/lib/python2.7/site-packages/salt/cloud/clouds/vmware.py", line 1404, in list_nodes_min
    vm_list = _get_mors_with_properties(vim.VirtualMachine, vm_properties)
  File "/usr/lib/python2.7/site-packages/salt/cloud/clouds/vmware.py", line 282, in _get_mors_with_properties
    content = _get_content(obj_type, property_list)
  File "/usr/lib/python2.7/site-packages/salt/cloud/clouds/vmware.py", line 232, in _get_content
    si = _get_si()
  File "/usr/lib/python2.7/site-packages/salt/cloud/clouds/vmware.py", line 211, in _get_si
    raise SaltCloudSystemExit(err_msg)
SaltCloudSystemExit: Could not connect to the specified vCenter server. Please check the debug log for more information
...
Contributor

steverweber commented on salt/utils/vmware.py in a7c2ad5 Feb 16, 2016

I think raise SaltSystemExit(err_msg) causes issues.
this might be fine when using salt-cloud... however users like myself use states.

When using highstate or salt-call the other states should continue...

salt-call state.apply example.cloud.vms
got stuck after SaltSystemExit...

[DEBUG   ] LazyLoaded rackspace.list_locations
[DEBUG   ] [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:765)
[DEBUG   ] Failed to execute 'vmware.list_nodes_min()' while querying for running nodes: Could not connect to the specified vCenter server. Please check the debug log for more information
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/salt/cloud/__init__.py", line 2269, in run_parallel_map_providers_query
    cloud.clouds[data['fun']]()
  File "/usr/lib/python2.7/site-packages/salt/cloud/clouds/vmware.py", line 1404, in list_nodes_min
    vm_list = _get_mors_with_properties(vim.VirtualMachine, vm_properties)
  File "/usr/lib/python2.7/site-packages/salt/cloud/clouds/vmware.py", line 282, in _get_mors_with_properties
    content = _get_content(obj_type, property_list)
  File "/usr/lib/python2.7/site-packages/salt/cloud/clouds/vmware.py", line 232, in _get_content
    si = _get_si()
  File "/usr/lib/python2.7/site-packages/salt/cloud/clouds/vmware.py", line 211, in _get_si
    raise SaltCloudSystemExit(err_msg)
SaltCloudSystemExit: Could not connect to the specified vCenter server. Please check the debug log for more information
...

This comment has been minimized.

Show comment
Hide comment
@steverweber

steverweber Feb 16, 2016

Contributor

on second thought this might be fine...

Contributor

steverweber replied Feb 16, 2016

on second thought this might be fine...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment