New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all ignore_missing SLSes are catched #30354

Merged
merged 1 commit into from Jan 14, 2016

Conversation

Projects
None yet
2 participants
@anlutro
Copy link
Contributor

anlutro commented Jan 14, 2016

Previously, only the last statement in top.sls with ignore_missing: true would actually be effective, because self.ignored_pillars[saltenv] was constantly being overwritten.

Related PR: #19429

make sure *all* ignore_missing slses are catched
previously, only the last statement in top.sls with `ignore_missing:
true` would actually be effective.

@anlutro anlutro changed the title Make sure all ignore_missing slses are catched Make sure all ignore_missing SLSes are catched Jan 14, 2016

cachedout added a commit that referenced this pull request Jan 14, 2016

Merge pull request #30354 from alprs/fix-pillar_ignore_missing
Make sure all ignore_missing SLSes are catched

@cachedout cachedout merged commit 7ee61f0 into saltstack:2015.8 Jan 14, 2016

2 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #11311 — FAILURE
Details
jenkins/salt-pr-rs-ubuntu14.04-n Salt PR - RS Ubuntu 14 #8800 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12722 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #12418 — SUCCESS
Details
@cachedout

This comment has been minimized.

Copy link
Collaborator

cachedout commented Jan 14, 2016

Seems sensible. Thanks, @anlutro

@anlutro anlutro deleted the alprs:fix-pillar_ignore_missing branch Mar 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment