New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes suspected copy/paste error for zmq_filtering functionailty #30359

Merged
merged 1 commit into from Jan 20, 2016

Conversation

Projects
None yet
3 participants
@kingsquirrel152
Contributor

kingsquirrel152 commented Jan 14, 2016

Subscribing to ‘’ empty topic regardless of zmq_filtering setting will cause messages to be sent to all minions in the case zmq_filtering is set to true. Can confirm by enabling zmq_filtering on master and minion, running minion with debug log level, issuing a master command using -L targeting towards minion that is NOT the one you are watching the log of, you will see it report that it received a message not for that minion.

Relevant logs below of me targeting just Node0 - other nodes still get the message.

==> Node1/rootfs/var/log/salt/minion <==
2016-01-13 20:35:09,109 [salt.transport.zeromq][DEBUG   ][1099] Publish received for not this minion: 542b9d66a1669f36607c8f24faff098d69f6316d

==> Node2/rootfs/var/log/salt/minion <==
2016-01-13 20:35:09,109 [salt.transport.zeromq][DEBUG   ][1086] Publish received for not this minion: 542b9d66a1669f36607c8f24faff098d69f6316d

==> Node3/rootfs/var/log/salt/minion <==
2016-01-13 20:35:09,108 [salt.transport.zeromq][DEBUG   ][1068] Publish received for not this minion: 542b9d66a1669f36607c8f24faff098d69f6316d

==> Node0/rootfs/var/log/salt/minion <==
2016-01-13 20:35:09,111 [salt.minion      ][INFO    ][1078] User sudo_vagrant Executing command sys.list_modules with jid 20160113203509105836
2016-01-13 20:35:09,111 [salt.minion      ][DEBUG   ][1078] Command details {'tgt_type': 'list', 'jid': '20160113203509105836', 'tgt': ['Node0'], 'ret': '', 'user': 'sudo_vagrant', 'arg': [], 'fun': 'sys.list_modules'}
2016-01-13 20:35:09,118 [salt.minion      ][INFO    ][1518] Starting a new job with PID 1518
2016-01-13 20:35:09,120 [salt.minion      ][DEBUG   ][1518] Minion return retry timer set to 7 seconds (randomized)
2016-01-13 20:35:09,120 [salt.minion      ][INFO    ][1518] Returning information for job: 20160113203509105836
2016-01-13 20:35:09,121 [salt.transport.zeromq][DEBUG   ][1518] Initializing new AsyncZeroMQReqChannel for ('/etc/salt/pki/minion', 'Node0', 'tcp://10.0.3.12:4506', 'aes')
2016-01-13 20:35:09,121 [salt.crypt       ][DEBUG   ][1518] Initializing new SAuth for ('/etc/salt/pki/minion', 'Node0', 'tcp://10.0.3.12:4506')```
Removes suspected copy/paste error.
Subscribing to ‘’ empty topic regardless of zmq_filtering setting
breaks function.

@kingsquirrel152 kingsquirrel152 changed the title from Removes suspected copy/paste error. to Removes suspected copy/paste error for zmq_filtering functionailty Jan 14, 2016

@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Jan 14, 2016

Contributor

Thanks, @kingsquirrel152

@jacksontj This was your code. How does this look to you?

Contributor

cachedout commented Jan 14, 2016

Thanks, @kingsquirrel152

@jacksontj This was your code. How does this look to you?

@jacksontj

This comment has been minimized.

Show comment
Hide comment
@jacksontj

jacksontj Jan 20, 2016

Contributor

+1 thanks for the catch ;)

Contributor

jacksontj commented Jan 20, 2016

+1 thanks for the catch ;)

@kingsquirrel152

This comment has been minimized.

Show comment
Hide comment
@kingsquirrel152

kingsquirrel152 Jan 20, 2016

Contributor

Quite welcome @jacksontj . I've been diving through the zeromq layers and it caught my eye. Im working on a PR that will show up soon that will support Master side matches so zmq_filtering will work for more than just list matches.

Contributor

kingsquirrel152 commented Jan 20, 2016

Quite welcome @jacksontj . I've been diving through the zeromq layers and it caught my eye. Im working on a PR that will show up soon that will support Master side matches so zmq_filtering will work for more than just list matches.

cachedout added a commit that referenced this pull request Jan 20, 2016

Merge pull request #30359 from distil/zmq_filtering_bug_fix
Removes suspected copy/paste error for zmq_filtering functionailty

@cachedout cachedout merged commit e425cbd into saltstack:2015.8 Jan 20, 2016

2 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #11316 — FAILURE
Details
jenkins/salt-pr-rs-ubuntu14.04-n Salt PR - RS Ubuntu 14 #8804 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12726 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #12422 — SUCCESS
Details
@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Jan 20, 2016

Contributor

Thanks to you both. :]

Contributor

cachedout commented Jan 20, 2016

Thanks to you both. :]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment