New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropfile support for non-privileged salt-master user. #30382

Merged
merged 1 commit into from Jan 19, 2016

Conversation

Projects
None yet
2 participants
@wdoekes
Copy link
Contributor

wdoekes commented Jan 15, 2016

In 02d9684, a check was added to ensure that the crypto dfn file was
made writable on windows before overwriting it. However, read-only
files are not only read-only on windows, they are read-only for
non-privileged users as well.

If you run the salt-master as a non-privileged user, you would observe
that the first child -- running _clear_old_jobs -- disappeared (went
defunct/zombie) after a while. This patch fixes the cause of the
problem.


The dropfile function itself was tested on 'develop'. The problem of the
zombie _clear_old_jobs was observed with version 0.17.5+ds-1, but
it seems reasonable to assume the bug manifests itself in develop as
well.

Long explanation can be found here:
http://wjd.nu/notes/2016#salt-master-losing-children

Thanks for a great product!

Fix dropfile support for non-privileged salt-master user.
In 02d9684, a check was added to ensure that the crypto dfn file was
made writable on windows before overwriting it.  However, read-only
files are not only read-only on windows, they are read-only for
non-privileged users as well.

If you run the salt-master as a non-privileged user, you would observe
that the first child -- running _clear_old_jobs -- disappeared (went
defunct/zombie) after a while.  This patch fixes the cause of the
problem.

cachedout pushed a commit that referenced this pull request Jan 19, 2016

Mike Place
Merge pull request #30382 from ossobv/ossobv-fix-dropfile-for-nonpriv…
…ileged-user

Fix dropfile support for non-privileged salt-master user.

@cachedout cachedout merged commit b4c8287 into saltstack:develop Jan 19, 2016

2 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #11360 — FAILURE
Details
jenkins/salt-pr-rs-ubuntu14.04-n Salt PR - RS Ubuntu 14 #8847 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12769 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #12465 — SUCCESS
Details
@cachedout

This comment has been minimized.

Copy link
Contributor

cachedout commented Jan 19, 2016

Great explanation and wonderful fix! Thanks, @wdoekes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment