New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure private AND public IPs are listed for Linode driver #30453

Merged
merged 1 commit into from Jan 20, 2016

Conversation

Projects
None yet
2 participants
@rallytime
Contributor

rallytime commented Jan 19, 2016

Fixes #30442

Also simplifies the return of the get_ips function to be used in other linode driver functions.

Without this fix, the list_nodes function looks like this, where the public IP gets overwritten with an empty list:

linode-config:
    ----------
    linode:
        ----------
        nt-u-1:
            ----------
            id:
                1601481
            image:
                Ubuntu
            name:
                nt-u-1
            private_ips:
                - 1.2.3.4
            public_ips:
            size:
                2048
            state:
                Running

With the fix, both the private and public IPs are listed:

linode-config:
    ----------
    linode:
        ----------
        nt-u-1:
            ----------
            id:
                1601481
            image:
                Ubuntu
            name:
                nt-u-1
            private_ips:
                - 1.2.3.4
            public_ips:
                - 5.6.7.8
            size:
                2048
            state:
                Running
Make sure private AND public IPs are listed for Linode driver
Fixes #30442

Also simplifies the return of the get_ips function to be used in
other places.

cachedout added a commit that referenced this pull request Jan 20, 2016

Merge pull request #30453 from rallytime/fix-30442
Make sure private AND public IPs are listed for Linode driver

@cachedout cachedout merged commit e706b71 into saltstack:2015.8 Jan 20, 2016

4 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12842 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #12530 — SUCCESS
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #11426 — SUCCESS
Details
jenkins/salt-pr-rs-ubuntu14.04-n Salt PR - RS Ubuntu 14 #8912 — SUCCESS
Details

@rallytime rallytime deleted the rallytime:fix-30442 branch Jan 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment