New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zypper: info_installed — 'errors' flag change to type 'boolean' #30494

Merged
merged 4 commits into from Jan 21, 2016

Conversation

Projects
None yet
3 participants
@isbm
Contributor

isbm commented Jan 21, 2016

Small "cosmetic" update: it is better to have 'errors' as 'true|false' instead of some keywords, since it only turns ON/OFF the state of error reporting.

Show outdated Hide outdated salt/modules/zypper.py Outdated
@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Jan 21, 2016

Contributor

@isbm I left a comment in-line. Could you please have a look? Thanks.

Contributor

cachedout commented Jan 21, 2016

@isbm I left a comment in-line. Could you please have a look? Thanks.

@isbm

This comment has been minimized.

Show comment
Hide comment
@isbm

isbm Jan 21, 2016

Contributor

@cachedout wrong merge 😉 Fixed, thanks!

Contributor

isbm commented Jan 21, 2016

@cachedout wrong merge 😉 Fixed, thanks!

cachedout added a commit that referenced this pull request Jan 21, 2016

Merge pull request #30494 from isbm/isbm-zypper-nfoinst-bool-fix
Zypper: info_installed — 'errors' flag change to type 'boolean'

@cachedout cachedout merged commit 3259fde into saltstack:2015.8 Jan 21, 2016

4 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12909 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #12597 — SUCCESS
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #11498 — SUCCESS
Details
jenkins/salt-pr-rs-ubuntu14.04-n Salt PR - RS Ubuntu 14 #8979 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment