New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly remove newlines after reading the file #30506

Merged
merged 1 commit into from Jan 21, 2016

Conversation

Projects
None yet
4 participants
@jacksontj
Contributor

jacksontj commented Jan 21, 2016

This means if there are additional newline characters in the config (which have no meaning for ifcfg) then we won't see it as a diff.

Judging from the comments on the original code this was intended @bretep

Properly remove newlines after reading the file
This means if there are additional newline characters in the config (which have no meaning for ifcfg) then we won't see it as a diff
@bretep

This comment has been minimized.

Show comment
Hide comment
@bretep

bretep Jan 21, 2016

Contributor

Thanks @jacksontj

Contributor

bretep commented Jan 21, 2016

Thanks @jacksontj

cachedout added a commit that referenced this pull request Jan 21, 2016

Merge pull request #30506 from jacksontj/2015.8
Properly remove newlines after reading the file

@cachedout cachedout merged commit 5968923 into saltstack:2015.8 Jan 21, 2016

4 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12910 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #12598 — SUCCESS
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #11499 — SUCCESS
Details
jenkins/salt-pr-rs-ubuntu14.04-n Salt PR - RS Ubuntu 14 #8980 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment