New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salt Virt cleanup #30549

Merged
merged 2 commits into from Jan 22, 2016

Conversation

Projects
None yet
2 participants
@techhat
Member

techhat commented Jan 22, 2016

This PR largely contains cleanup work, but it also includes switching key management from auto-accept to manually creating and pre-populating keys.

Ping @Ch3LL.

@techhat

This comment has been minimized.

Show comment
Hide comment
@techhat

techhat Jan 22, 2016

Member

Also, deprecated "hyper" in favor of "host".

Member

techhat commented Jan 22, 2016

Also, deprecated "hyper" in favor of "host".

@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Jan 22, 2016

Contributor

@techhat There is a lint error that suggests that a variable might need to be renamed. Could you please take a look?

Contributor

cachedout commented Jan 22, 2016

@techhat There is a lint error that suggests that a variable might need to be renamed. Could you please take a look?

@techhat

This comment has been minimized.

Show comment
Hide comment
@techhat
Member

techhat commented Jan 22, 2016

@cachedout, fixed.

cachedout added a commit that referenced this pull request Jan 22, 2016

@cachedout cachedout merged commit 2eb5a38 into saltstack:2015.8 Jan 22, 2016

1 of 5 checks passed

jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #11612 — FAILURE
Details
default Merged build started.
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #12655 — RUNNING
Details
jenkins/salt-pr-rs-ubuntu14.04-n Salt PR - RS Ubuntu 14 #9037 — RUNNING
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12967 — SUCCESS
Details
@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Jan 22, 2016

Contributor

@techhat Thanks!

Contributor

cachedout commented Jan 22, 2016

@techhat Thanks!

@techhat techhat deleted the techhat:virtcleanup branch Jan 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment