New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Napalm library based proxy minion #31431

Merged
merged 1 commit into from Feb 23, 2016

Conversation

Projects
None yet
4 participants
@jejenone
Copy link
Contributor

jejenone commented Feb 23, 2016

This is a proxy minion working with Napalm library (https://github.com/napalm-automation/napalm)
This allows to manage network devices currently supported by Napalm: Juniper, Cisco, Arista, etc.
We provide a limited module to retrieve:

  • CLI outputs
  • MAC address table
  • ARP table
  • LLDP neighbors

@jejenone jejenone force-pushed the jejenone:napalm_proxy_minion branch 3 times, most recently from dee61cf to 54ce874 Feb 23, 2016

@cachedout

This comment has been minimized.

Copy link
Collaborator

cachedout commented Feb 23, 2016

Looks great. We do have a lint error that needs to be cleaned up here before we can merge this. Please let me know when a fix has been pushed for that.

I am also going to ask @cro to take a look here, since he's the original author of the proxy-minion system.

@jejenone

This comment has been minimized.

Copy link
Contributor

jejenone commented Feb 23, 2016

I can't see the lint error - it says "no identified error" here: https://jenkins.saltstack.com/job/salt-pr-lint-n/13692/

@cro

This comment has been minimized.

Copy link
Member

cro commented Feb 23, 2016

@jejenone This is a great addition, thanks so much for contributing!

Try this for the lint error:

https://jenkins.saltstack.com/job/salt-pr-lint-n/13692/violations/file/salt/modules/napalm_network.py/

It's trailing whitespace.

@jejenone jejenone force-pushed the jejenone:napalm_proxy_minion branch from 54ce874 to 8ad5794 Feb 23, 2016

@jejenone

This comment has been minimized.

Copy link
Contributor

jejenone commented Feb 23, 2016

@cro weird I thought I had removed the spaces but there was one left.
Anyway, fixed. Thanks!

cachedout added a commit that referenced this pull request Feb 23, 2016

Merge pull request #31431 from jejenone/napalm_proxy_minion
Napalm library based proxy minion

@cachedout cachedout merged commit 437b983 into saltstack:develop Feb 23, 2016

2 of 5 checks passed

default Merged build started.
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #12757 — RUNNING
Details
jenkins/salt-pr-rs-ubuntu14.04-n Salt PR - RS Ubuntu 14 #10079 — RUNNING
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #14017 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #13697 — SUCCESS
Details

@jejenone jejenone deleted the jejenone:napalm_proxy_minion branch Feb 23, 2016

@mirceaulinic mirceaulinic referenced this pull request Mar 22, 2016

Merged

New module: NAPALM_NTP, using NAPALM proxy #32043

1 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment