Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nspawn.py: Fix bad keyword assignment #31529

Merged
merged 1 commit into from Mar 1, 2016

Conversation

Projects
None yet
3 participants
@llua
Copy link
Contributor

commented Feb 28, 2016

Currently every keyword for _pull_image is considered a bad keyword.

% salt node nspawn.pull_tar url bar
ERROR executing 'nspawn.pull_tar': The following invalid keyword arguments were passed: verify=False.
nspawn.py: Fix bad keyword assignment
Currently every keyword for _pull_image is considered a bad keyword.

```
% salt node nspawn.pull_tar url bar
ERROR executing 'nspawn.pull_tar': The following invalid keyword arguments were passed: verify=False.
```
@cachedout

This comment has been minimized.

Copy link
Collaborator

commented Feb 29, 2016

@terminalmage This is your code. Could you please take a look?

@terminalmage

This comment has been minimized.

Copy link
Contributor

commented Feb 29, 2016

@llua Good catch, but since my original code was written we have gotten better ways off handling bad kwargs via a couple of functions in salt.utils. I have opened #31546 which pulls in your fix here and then makes it use the newer code.

When #31546 is merged, Github will automagically mark this PR as merged since my PR contains all the commits from this one.

Thanks!

@llua

This comment has been minimized.

Copy link
Contributor Author

commented Mar 1, 2016

sounds good to me.

@cachedout cachedout merged commit 17f7a2d into saltstack:develop Mar 1, 2016

3 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #12886 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #14141 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #13821 — SUCCESS
Details
jenkins/salt-pr-rs-ubuntu14.04-n Salt PR - RS Ubuntu 14 #10203 — SUCCESS
Details

cachedout pushed a commit that referenced this pull request Mar 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.