Proxies don't handle reusing the SmartConnect instances very well. D… #35673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cro Linter doesn't like that. Could you please take another look? |
cachedout
added
the
Pending-Discussion
…n't attempt to used the cached ones.
…n't attempt to used the cached ones.
|
@cro Now failing some VMware tests. |
|
@cachedout @rallytime Looks like I fixed the related failing VMware tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevents proxy minions from re-using cached SmartConnect instances.
Previous Behavior
Proxies would hang or throw confusing stacktraces but only after the first time they talk to the VMware endpoints.
New Behavior
Calls to the proxy after the first one continue to work.