FreeBSD sysctl module now handels config_file parameter in show method #36794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the possibility to read sysctl key/values from a given config_file on FreeBSD. The sysctl state module did already pass the
config_file
parameter to the FreeBSD execution module although it never got handled there. The fact that the module now collects currently configured sysctl values directly from file and not viacmd.run
is reducing the execution time on FreeBSD by approx 50%.What issues does this PR fix or reference?
This PR is just one part of #36707 which can be back ported to existing versions.
I will open another PR for the same bug later on that adds additional features.
Previous Behavior
Total execution time of 3 randomly picked sysctl states against a FreeBSD 10.3 salt minion:
New Behavior
Total execution time of the same 3 sysctl states against a FreeBSD 10.3 salt minion:
Duration for each State is now ~2.8 seconds compared to ~5.2 seconds before.
Tests written?
No