Avoid Early Convert ret['comment'] to String #37424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes this exception:
An exception occurred in this state: Traceback (most recent call last):
File "/var/tmp/.syops_b1274f_salt/py2/salt/state.py", line 1733, in call
**cdata['kwargs'])
File "/var/tmp/.syops_b1274f_salt/py2/salt/loader.py", line 1652, in wrapper
return f(*args, **kwargs)
File "/var/tmp/.syops_b1274f_salt/py2/salt/states/gpg.py", line 119, in present
ret['comment'].append('Adding {0} to GPG keychain'.format(name))
AttributeError: 'str' object has no attribute 'append'
kojiromike
force-pushed
the
gpg-no-append-method-on-string
branch
from
790d93b
to
ceb7735
Compare
|
Thank you, @kojiromike |
gtmanfred
added
the
bugfix-bckport
rallytime
added
ZZZ[Done]-back-ported-bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes this exception:
What issues does this PR fix or reference?
The code that mutates the
ret['comment']from a list to a string happens inside a loop. It should happen just before returning.Previous Behavior
You can only use the gpg.present state with one key at a time, or it will crash.
New Behavior
You can now use the gpg state with multiple keys, as documented.
Tests written?
No
Please review Salt's Contributing Guide for best practices.