Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grains.setval performance #39431

merged 2 commits into from Feb 15, 2017


None yet
2 participants
Copy link

commented Feb 15, 2017

What does this PR do?

Adds a refresh option to grains.setval and grains.setvals. Setting refresh=False will cause the grain to be set, but saltutil.sync_grains will not be called.

What issues does this PR fix or reference?


Tests written?


Please review Salt's Contributing Guide for best practices.


This comment has been minimized.

Copy link

commented Feb 15, 2017

Since this is a serious performance problem under certain configurations, it's reasonable to classify this as a bug and not a feature. Therefore, I'll go ahead and get this in. Thanks, @UtahDave

@cachedout cachedout merged commit 5616270 into saltstack:2016.3 Feb 15, 2017

6 checks passed

default Pull Requests » Salt PR - Main Build #1724
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #11270 — SUCCESS
jenkins/PR/salt-pr-docs-n Pull Requests » salt-pr-docs-n #4112 — SUCCESS
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt Linode Ubuntu14.04 #8561 — SUCCESS
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #8638 — SUCCESS
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #8785 — SUCCESS

This comment has been minimized.

Copy link
Member Author

commented Feb 16, 2017

Thank you, @cachedout !

@UtahDave UtahDave deleted the UtahDave:fix_grains.setval_performance branch Feb 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.