Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly parse "pkg_name===version" from pip freeze #40038

Merged
merged 1 commit into from Mar 15, 2017

Conversation

Projects
None yet
5 participants
@velom
Copy link
Contributor

commented Mar 15, 2017

What does this PR do?

In some cases pip freeze returns lines like pkg_name===version
It's mean that states like

"Install pip packages":
  pip.installed:
    - pkgs:
      - my-pkg == 0.23-version-2748

always return changes=True

My PR add additional if for three equal symbols

Previous Behavior

# salt-call pip.freeze
local:
    - my-pkg===0.23-version-2748
# salt-call pip.list my-pkg
local:
    ----------
    my-pkg:
        =0.23-version-2748

New Behavior

# salt-call pip.freeze
local:
    - my-pkg===0.23-version-2748
# salt-call pip.list my-pkg
local:
    ----------
    my-pkg:
        0.23-version-2748

Tests written?

No

@salt-jenkins

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2017

@velom, thanks for your PR! By analyzing the history of the files in this pull request, we identified @s0undt3ch, @fxdgear and @terminalmage to be potential reviewers.

@terminalmage

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2017

@velom The 2014.1 branch is end-of-life, can you please resubmit this against 2016.3?

@terminalmage

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2017

You can rebase it onto that branch and simply edit the head branch of this PR so that you don't need to close it and open a new one.

@velom velom force-pushed the velom:fix-pip-freeze-parsing branch from c3915b2 to 3fae91d Mar 15, 2017

@velom velom changed the base branch from 2014.1 to 2016.3 Mar 15, 2017

@velom

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2017

@terminalmage Simply cherry-picked my only commit for 2016.3 base

@fxdgear

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2017

I haven't touched this code in 5 years. I'm not certain my input will be valid :(

@cachedout

This comment has been minimized.

Copy link
Collaborator

commented Mar 15, 2017

@fxdgear No worries. Sometimes the automated bot can cast too wide a net. ;] Thanks.

@cachedout cachedout merged commit 22fc529 into saltstack:2016.3 Mar 15, 2017

6 checks passed

default Pull Requests » Salt PR - Main Build #2606
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #12155 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » salt-pr-docs-n #4992 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt Linode Ubuntu14.04 #9467 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #9527 — SUCCESS
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #9671 — SUCCESS
Details

@velom velom deleted the velom:fix-pip-freeze-parsing branch Mar 15, 2017

@terminalmage

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2017

@velom that works too. Thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.