Add wait_for_fun() to set_tags() #40225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@techhat, thanks for your PR! By analyzing the history of the files in this pull request, we identified @s0undt3ch, @abemusic and @rallytime to be potential reviewers. |
cachedout
approved these changes
Mar 22, 2017
|
@techhat and @cachedout this has a pylint error in it. |
|
Bah. Sorry! |
|
I'm going to revert this and ask @techhat to re-submit it. |
|
I'll get it done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sometimes
set_tags()doesn't work during the creation process because not all of the required data is available yet. This causes a wait of up to 30 seconds for that function to happen.What issues does this PR fix or reference?
ZD-1239
Tests written?
No.