Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump removal version from Oxygen to Flourine for module.run state #41219

Merged

Conversation

rallytime
Copy link
Contributor

@rallytime rallytime commented May 12, 2017

This deprecation code was only recently put in for the nitrogen release. The policy is to give at least 2 feature releases before the deprecated code is removed. See the Deprecating Code docs for more information.

This PR bumps the warn_until/removal version from Oxygen to Fluorine to give people more time to adjust their state modules with 2 feature releases.

Refs #39891

This deprecation code was only recently put in for the `nitrogen`
release. The policy is to give at least 2 feature releases before
the deprecated code is removed. See the [Deprecating Code](https://docs.saltstack.com/en/latest/topics/development/deprecations.html)
docs for more information.

This PR bumps the warn_until/removal version from Oxygen to Fluorine
to give people more time to adjust their state modules.
@ghost
Copy link

@ghost ghost commented May 12, 2017

@rallytime, thanks for your PR! By analyzing the history of the files in this pull request, we identified @isbm, @thatch45 and @terminalmage to be potential reviewers.

@cachedout cachedout merged commit ab76fc6 into saltstack:nitrogen May 17, 2017
6 checks passed
@rallytime rallytime deleted the bump-module-state-deprecation branch May 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants