New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only force saltenv/pillarenv to be a string when not None #42433

Merged
merged 1 commit into from Jul 20, 2017

Conversation

Projects
None yet
7 participants
@terminalmage
Member

terminalmage commented Jul 20, 2017

This fixes a regression introduced to make numeric saltenv/pillarenv
work properly.

Fixes #42403

Only force saltenv/pillarenv to be a string when not None
This fixes a regression introduced to make numeric saltenv/pillarenv
work properly.
@salt-jenkins

This comment has been minimized.

Show comment
Hide comment
@salt-jenkins

salt-jenkins Jul 20, 2017

Contributor

@terminalmage, thanks for your PR! By analyzing the history of the files in this pull request, we identified @thatch45, @cachedout and @garethgreenaway to be potential reviewers.

Contributor

salt-jenkins commented Jul 20, 2017

@terminalmage, thanks for your PR! By analyzing the history of the files in this pull request, we identified @thatch45, @cachedout and @garethgreenaway to be potential reviewers.

@cachedout cachedout merged commit 82982f9 into saltstack:2017.7 Jul 20, 2017

8 checks passed

default Build finished.
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #15599 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #8404 — SUCCESS
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #371 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #12988 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #384 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #12940 — SUCCESS
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #13089 — SUCCESS
Details
@sokratisg

This comment has been minimized.

Show comment
Hide comment
@sokratisg

sokratisg Jul 21, 2017

When should this be available in the package repos?

sokratisg commented Jul 21, 2017

When should this be available in the package repos?

garethgreenaway added a commit that referenced this pull request Jul 21, 2017

@gtmanfred

This comment has been minimized.

Show comment
Hide comment
@gtmanfred

gtmanfred Jul 26, 2017

Member

This needs to be backported to 2016.11 as well

Member

gtmanfred commented Jul 26, 2017

This needs to be backported to 2016.11 as well

@damon-atkins

This comment has been minimized.

Show comment
Hide comment
@damon-atkins

damon-atkins Jul 27, 2017

Contributor

I suggest this is handled higher up in parsing of the command line for salt and salt-call, as a lots of functions are feed saltenv and they would all need the same bit of code. (And maybe the client code that accepts the request from the master)

Contributor

damon-atkins commented Jul 27, 2017

I suggest this is handled higher up in parsing of the command line for salt and salt-call, as a lots of functions are feed saltenv and they would all need the same bit of code. (And maybe the client code that accepts the request from the master)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment