Fix disable_<tag-name> config option #42567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the logic always looked for `disable_<tag-name>s` in the config options. The issue with this is that the following tag names already end with 's': `beacons`, `engines`, `grains`, `log_handlers`, `serializers`, `states`, and `utils`. So previously, if you wanted to disable a beacon, the config option to set is `disable_beaconss` (with 'ss' at the end). Fix this so that we only append an 's' if the tag name does not already end with an 's'. Signed-off-by: Sergey Kizunov <sergey.kizunov@ni.com>
|
@skizunov, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jacksontj, @thatch45 and @s0undt3ch to be potential reviewers. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously, the logic always looked for
disable_<tag-name>sinthe config options. The issue with this is that the following tag names
already end with 's':
beacons,engines,grains,log_handlers,serializers,states, andutils. So previously, if you wanted todisable a beacon, the config option to set is
disable_beaconss(with'ss' at the end). Fix this so that we only append an 's' if the tag name
does not already end with an 's'.
Tests written?
No