Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use superseded and deprecated configuration from pillar #42602

Conversation

garethgreenaway
Copy link
Member

@garethgreenaway garethgreenaway commented Jul 27, 2017

What does this PR do?

Updating the superseded and deprecated decorators to work when specified as pillar values.

What issues does this PR fix or reference?

#42514

Previous Behavior

Previously the list of functions for use_superseded and use_deprecated were specified in minion configuration.

New Behavior

Specify the list of functions for use_superseded and use_deprecated as pillar values.

Tests written?

No

Please review Salt's Contributing Guide for best practices.

@ghost
Copy link

@ghost ghost commented Jul 27, 2017

@garethgreenaway, thanks for your PR! By analyzing the history of the files in this pull request, we identified @isbm, @rallytime and @s0undt3ch to be potential reviewers.

@garethgreenaway
Copy link
Member Author

@garethgreenaway garethgreenaway commented Jul 27, 2017

Go Go Jenkins!

full_name in pillar.get(self.CFG_USE_DEPRECATED, list())

use_superseded = full_name in opts.get(self.CFG_USE_SUPERSEDED, list()) or \
full_name in pillar.get(self.CFG_USE_SUPERSEDED, list())
Copy link
Collaborator

@isbm isbm Jul 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garethgreenaway Please do me a favour: remove the \ thing enclosing whole expression in (...) :-)

isbm
isbm approved these changes Jul 28, 2017
Copy link
Collaborator

@isbm isbm left a comment

@garethgreenaway 👍 for this and + 💯 and one hug for great unit tests! Great job!

@garethgreenaway
Copy link
Member Author

@garethgreenaway garethgreenaway commented Jul 28, 2017

Go Go Jenkins!

2 similar comments
@garethgreenaway
Copy link
Member Author

@garethgreenaway garethgreenaway commented Jul 28, 2017

Go Go Jenkins!

@garethgreenaway
Copy link
Member Author

@garethgreenaway garethgreenaway commented Jul 31, 2017

Go Go Jenkins!

@garethgreenaway garethgreenaway merged commit 25094ad into saltstack:2017.7 Jul 31, 2017
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants