Use superseded and deprecated configuration from pillar #42602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ied as pillar values.
…s to also test for pillar values.
|
@garethgreenaway, thanks for your PR! By analyzing the history of the files in this pull request, we identified @isbm, @rallytime and @s0undt3ch to be potential reviewers. |
Contributor
Author
|
Go Go Jenkins! |
isbm
reviewed
Jul 28, 2017
salt/utils/decorators/__init__.py
Outdated
| full_name in pillar.get(self.CFG_USE_DEPRECATED, list()) | ||
|
|
||
| use_superseded = full_name in opts.get(self.CFG_USE_SUPERSEDED, list()) or \ | ||
| full_name in pillar.get(self.CFG_USE_SUPERSEDED, list()) |
Contributor
There was a problem hiding this comment.
@garethgreenaway Please do me a favour: remove the \ thing enclosing whole expression in (...) :-)
isbm
approved these changes
Jul 28, 2017
Contributor
isbm
left a comment
isbm
left a comment
There was a problem hiding this comment.
@garethgreenaway 👍 for this and + 💯 and one hug for great unit tests! Great job!
Contributor
Author
|
Go Go Jenkins! |
2 similar comments
Contributor
Author
|
Go Go Jenkins! |
Contributor
Author
|
Go Go Jenkins! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updating the superseded and deprecated decorators to work when specified as pillar values.
What issues does this PR fix or reference?
#42514
Previous Behavior
Previously the list of functions for use_superseded and use_deprecated were specified in minion configuration.
New Behavior
Specify the list of functions for use_superseded and use_deprecated as pillar values.
Tests written?
No
Please review Salt's Contributing Guide for best practices.