Fix unit.test_test_module_names for Windows
#42997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@twangboy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @s0undt3ch and @meaksh to be potential reviewers. |
|
Go Go Jenkins! |
|
@twangboy Could you please rebase this against the head of 2017.7? |
twangboy
force-pushed
the
win_fix_test_module_names
branch
from
b7f3a98
to
2722e95
Compare
|
Rebased |
cachedout
approved these changes
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses os.path.join to create paths instead of hard-coded, unix-style paths.
What issues does this PR fix or reference?
saltstack/salt-ci-images#439
Tests written?
Yes