saltcheck module

[wcannon]

What does this PR do?

This pull request adds a salt module for salt state logic checking

What issues does this PR fix or reference?

none

New Behavior

Remove this section if not relevant
Allows for unit-test-like testing of salt states and highstates

Tests written?

Yes

Please review Salt's Contributing Guide for best practices.

[cachedout]

I do like this quite a lot but I wouldn't feel comfortable getting it in until there is more substantial documentation in the Salt docs themselves, versus just having it in the module.

@gtmanfred What do you think about perhaps creating a Testing tutorial that talks about both this approach and the new salt-kitchen stuff?

[gtmanfred]

I think that would be great!

[wcannon]

Adding a tutorial seems very sensible. So, how should we proceed?

…

On Mon, Aug 21, 2017 at 6:40 PM, Daniel Wallace ***@***.***> wrote: I think that would be great! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#43065 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3k_ceP1Q7rBdM8YvmOfQTvF1EIwy3Sks5sahVogaJpZM4O8Eq2> .

[cachedout]

@wcannon or @gtmanfred Any volunteers to start on a tutorial? :] I'm happy to merge this before then but it would be great if we could get started ASAP so it's not forgotten.

[gtmanfred]

I will add it to my list.

[wcannon]

Mike - a couple questions about this: 1. what format should be used? 2. where should the tutorial be placed for review? 3. any specific content you would like to see in the tutorial? I'm open to suggestions.

…

On Wed, Aug 23, 2017 at 12:30 PM, Mike Place ***@***.***> wrote: @wcannon <https://github.com/wcannon> or @gtmanfred <https://github.com/gtmanfred> Any volunteers to start on a tutorial? :] I'm happy to merge this before then but it would be great if we could get started ASAP so it's not forgotten. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#43065 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3k_Tsex2pAqB1nceEXYYu0edBfw7MCks5sbGGugaJpZM4O8Eq2> .

[gtmanfred]

@wcannon don't worry about the tutorial, I am going to go through and document all of this. I will be giving a talk about testing salt states for SaltConf 2017

…

On Fri, Aug 25, 2017 at 11:21 AM, wcannon ***@***.***> wrote: Mike - a couple questions about this: 1. what format should be used? 2. where should the tutorial be placed for review? 3. any specific content you would like to see in the tutorial? I'm open to suggestions. On Wed, Aug 23, 2017 at 12:30 PM, Mike Place ***@***.***> wrote: > @wcannon <https://github.com/wcannon> or @gtmanfred > <https://github.com/gtmanfred> Any volunteers to start on a tutorial? :] > I'm happy to merge this before then but it would be great if we could get > started ASAP so it's not forgotten. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#43065 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AA3k_ Tsex2pAqB1nceEXYYu0edBfw7MCks5sbGGugaJpZM4O8Eq2> > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#43065 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAssoW0R_RnVspsI3gtbLemPmaWRwPt4ks5sbwKSgaJpZM4O8Eq2> .

[wcannon]

Thanks Daniel (@gtmanfred). I'll skip working on the tutorial. btw, I'm giving a talk on testing salt states at saltconf too. See you there! On Fri, Aug 25, 2017 at 1:49 PM, Daniel Wallace <notifications@github.com> wrote:

…

@wcannon don't worry about the tutorial, I am going to go through and document all of this. I will be giving a talk about testing salt states for SaltConf 2017 On Fri, Aug 25, 2017 at 11:21 AM, wcannon ***@***.***> wrote: > Mike - a couple questions about this: > 1. what format should be used? > 2. where should the tutorial be placed for review? > 3. any specific content you would like to see in the tutorial? I'm open > to suggestions. > > On Wed, Aug 23, 2017 at 12:30 PM, Mike Place ***@***.***> > wrote: > > > @wcannon <https://github.com/wcannon> or @gtmanfred > > <https://github.com/gtmanfred> Any volunteers to start on a tutorial? :] > > I'm happy to merge this before then but it would be great if we could get > > started ASAP so it's not forgotten. > > > > — > > You are receiving this because you were mentioned. > > Reply to this email directly, view it on GitHub > > <#43065 (comment)>, > or mute > > the thread > > <https://github.com/notifications/unsubscribe-auth/AA3k_ > Tsex2pAqB1nceEXYYu0edBfw7MCks5sbGGugaJpZM4O8Eq2> > > > . > > > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#43065 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AAssoW0R_ RnVspsI3gtbLemPmaWRwPt4ks5sbwKSgaJpZM4O8Eq2> > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#43065 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3k_dyaufkqZ3QcZr0YsgkVIzB-GKg2ks5sbxcvgaJpZM4O8Eq2> .

[cachedout]

@gtmanfred How do you want to handle this. Do you want to just submit a PR to @wcannon 's branch or do something independently?

[gtmanfred]

Can we merge this PR, and then I will start on the documentation for this and the tutorial for testing next week?

Thanks,
Daniel

[cachedout]

@gtmanfred Yes, I have no problem with that at all. It does look like it failed a lint check though. I'll re-run the test and then hopefully @wcannon can fix it right up.

[cachedout]

re-run lint

[wcannon]

Anything else left to do?