Resolve image ID during container comparison #43155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@terminalmage, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ticosax, @dmacvicar and @mcalmer to be potential reviewers. |
This fixes an issue where inspecting the container returns an image ID instead of an image name, resulting in a spurious report of a changed image. By resolving the image down to its ID for both the existing and new containers, we ensure we're comparing ID to ID.
terminalmage
force-pushed
the
issue43001
branch
from
3c456d7
to
d5b2a0b
Compare
|
@terminalmage There's some lint errors here, I'm afraid. |
rallytime
approved these changes
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where inspecting the container returns an image ID
instead of an image name, resulting in a spurious report of a changed
image. By resolving the image down to its ID for both the existing and
new containers, we ensure we're comparing ID to ID.