Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always notify tkwilliams when changes occur on boto files #43206

Merged
merged 1 commit into from Aug 28, 2017

Conversation

@rallytime
Copy link
Contributor

rallytime commented Aug 25, 2017

Adds @tkwilliams to the alwaysNotifyForPaths option in .mention-bot for any boto files in Salt so he can see when changes are made automatically.

@salt-jenkins

This comment has been minimized.

Copy link
Contributor

salt-jenkins commented Aug 25, 2017

@rallytime, thanks for your PR! By analyzing the history of the files in this pull request, we identified @cachedout to be a potential reviewer.

Copy link
Collaborator

cachedout left a comment

Shouldn't this be on the 2016.11 branch though?

@rallytime

This comment has been minimized.

Copy link
Contributor Author

rallytime commented Aug 28, 2017

@cachedout Hm...possibly. I am not sure where mentionbot draws it's config from and if it cares about different branches or just pulls from develop. I can back-port this to be safe.

@cachedout

This comment has been minimized.

Copy link
Collaborator

cachedout commented Aug 28, 2017

It will pull from whatever branch the PR in question comes from, so yes, this will need a backport. Thanks!

@cachedout cachedout merged commit c666429 into saltstack:develop Aug 28, 2017
6 checks passed
6 checks passed
default Build finished.
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #16795 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #9585 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #14220 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #1461 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #14120 — SUCCESS
Details
@rallytime rallytime deleted the rallytime:tkwilliams-boto-mentionbot branch Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.