Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better qemu_static parameter mangle in deboostrap management, tests #43390

Merged
merged 3 commits into from Sep 11, 2017

Conversation

@aogier
Copy link

aogier commented Sep 7, 2017

What does this PR do?

Closes #43387 by managing associated module flag in a more sensible way

Tests written?

updated existing

@salt-jenkins

This comment has been minimized.

Copy link
Contributor

salt-jenkins commented Sep 7, 2017

@aogier, thanks for your PR! By analyzing the history of the files in this pull request, we identified @techhat, @jfindlay and @rupeshta to be potential reviewers.

@rallytime rallytime requested a review from gtmanfred Sep 7, 2017
Copy link
Contributor

gtmanfred left a comment

You will need to create a new function, but it doesn't matter if the qemu path is readable, only if it is executable.

@@ -403,6 +403,11 @@ def _bootstrap_deb(
log.error('Required tool debootstrap is not installed.')
return False

if static_qemu and not salt.utils.validate.path.is_readable(static_qemu):

This comment has been minimized.

Copy link
@gtmanfred

gtmanfred Sep 7, 2017

Contributor

shouldn't this be checking if the static_qemu path is executable?

@aogier

This comment has been minimized.

Copy link
Author

aogier commented Sep 7, 2017

@gtmanfred that's a good point, in fact this entire process will run as root or it will anyway fail creating chroot so yes, let's check only for executable bit thank you

@rallytime

This comment has been minimized.

Copy link
Contributor

rallytime commented Sep 8, 2017

@aogier It looks like there is a test failing here. Can you take a look?

@rallytime rallytime requested a review from gtmanfred Sep 8, 2017
Alessandro -oggei- Ogier
@aogier

This comment has been minimized.

Copy link
Author

aogier commented Sep 8, 2017

forgot to mock new method in tests, now it should go fine ! :)

@gtmanfred

This comment has been minimized.

Copy link
Contributor

gtmanfred commented Sep 8, 2017

Awesome, thanks!

@rallytime rallytime merged commit 57cccd7 into saltstack:2016.11 Sep 11, 2017
5 checks passed
5 checks passed
default Build finished.
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #17144 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #9908 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #14548 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #14451 — SUCCESS
Details
@aogier aogier deleted the aogier:43387-genesis-qemu branch Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.