New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Fixes to setup.py #43515

Merged
merged 4 commits into from Sep 17, 2017

Conversation

Projects
None yet
4 participants
@garethgreenaway
Member

garethgreenaway commented Sep 14, 2017

What does this PR do?

Following the change in #42103 if Salt is installed via setup.py then the generated _syspaths.py does not contain the HOME_DIR which results in a failure.

What issues does this PR fix or reference?

N/A

Previous Behavior

HOME_DIR was not be included in the _syspaths.py generated via setup.py

New Behavior

HOME_DIR is not included.

Tests written?

No

Please review Salt's Contributing Guide for best practices.

Following the change in #42103 if Salt is installed via setup.py then…
… the generated _syspaths.py does not contain the HOME_DIR which results in a failure.
@salt-jenkins

This comment has been minimized.

Show comment
Hide comment
@salt-jenkins

salt-jenkins Sep 14, 2017

Contributor

@garethgreenaway, thanks for your PR! By analyzing the history of the files in this pull request, we identified @s0undt3ch, @twangboy and @skizunov to be potential reviewers.

Contributor

salt-jenkins commented Sep 14, 2017

@garethgreenaway, thanks for your PR! By analyzing the history of the files in this pull request, we identified @s0undt3ch, @twangboy and @skizunov to be potential reviewers.

@@ -892,6 +894,7 @@ def __init__(self, attrs=None):
self.salt_spm_formula_dir = None
self.salt_spm_pillar_dir = None
self.salt_spm_reactor_dir = None
self.salt_home_dir = None

This comment has been minimized.

@s0undt3ch

s0undt3ch Sep 15, 2017

Member

You also need a salt-hime-dir entry in SaltDistribution.global_options or this value is not configurable at install time.

@s0undt3ch

s0undt3ch Sep 15, 2017

Member

You also need a salt-hime-dir entry in SaltDistribution.global_options or this value is not configurable at install time.

This comment has been minimized.

@s0undt3ch

s0undt3ch Sep 15, 2017

Member

salt-home-dir

@s0undt3ch

s0undt3ch Sep 15, 2017

Member

salt-home-dir

Show outdated Hide outdated setup.py Outdated
@s0undt3ch

This comment has been minimized.

Show comment
Hide comment
@s0undt3ch
Member

s0undt3ch commented Sep 17, 2017

Fixes #43562

@s0undt3ch s0undt3ch merged commit 826a25a into saltstack:develop Sep 17, 2017

6 checks passed

default Build finished.
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #17388 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #10139 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #14792 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #1993 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #14686 — SUCCESS
Details

@saltstack saltstack deleted a comment from KumarRajnish Sep 21, 2017

@openfly

This comment has been minimized.

Show comment
Hide comment
@openfly

openfly Apr 5, 2018

This appears to impact the 2018.3.0 release

openfly commented Apr 5, 2018

This appears to impact the 2018.3.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment