New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing generated syspaths #43563

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
3 participants
@epcim
Contributor

epcim commented Sep 17, 2017

What does this PR do?

Fixes missing path's on _generated_syspaths object.

What issues does this PR fix or reference?

#43562

Tests written?

No

@salt-jenkins

This comment has been minimized.

Show comment
Hide comment
@salt-jenkins

salt-jenkins Sep 17, 2017

Contributor

@epcim, thanks for your PR! By analyzing the history of the files in this pull request, we identified @davidjoliver86, @s0undt3ch and @terminalmage to be potential reviewers.

Contributor

salt-jenkins commented Sep 17, 2017

@epcim, thanks for your PR! By analyzing the history of the files in this pull request, we identified @davidjoliver86, @s0undt3ch and @terminalmage to be potential reviewers.

@s0undt3ch

This comment has been minimized.

Show comment
Hide comment
@s0undt3ch

s0undt3ch Sep 17, 2017

Member

Closing as a duplicate of #43515

Member

s0undt3ch commented Sep 17, 2017

Closing as a duplicate of #43515

@s0undt3ch s0undt3ch closed this Sep 17, 2017

@epcim

This comment has been minimized.

Show comment
Hide comment
@epcim

epcim Sep 17, 2017

Contributor

I understand that's actually due a bug, so will be fixed by other PR.
However this patch would probably sanitize the _generated_syspath object to expected content whatever was imported/generated.

Contributor

epcim commented Sep 17, 2017

I understand that's actually due a bug, so will be fixed by other PR.
However this patch would probably sanitize the _generated_syspath object to expected content whatever was imported/generated.

@s0undt3ch

This comment has been minimized.

Show comment
Hide comment
@s0undt3ch

s0undt3ch Sep 17, 2017

Member

The generated syspaths is configurable at install time and that's what we attempt to import. The way you shifted the scope of the variables iteration would reset whatever was configured at install time to None.
Yes, the logic beneath the code you changed would still work but it would break that install time configuration capability that was added to salt.

Member

s0undt3ch commented Sep 17, 2017

The generated syspaths is configurable at install time and that's what we attempt to import. The way you shifted the scope of the variables iteration would reset whatever was configured at install time to None.
Yes, the logic beneath the code you changed would still work but it would break that install time configuration capability that was added to salt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment