New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix names of NACL dec. methods #43564

Merged
merged 3 commits into from Sep 20, 2017

Conversation

Projects
None yet
5 participants
@epcim
Contributor

epcim commented Sep 17, 2017

What does this PR do?

Latest develp branch code called nacl.dec_pub method that is no longer available as we updated the original nacl implementation. Latest "dec" method recognize sealed_box and secret_box and use the appropriate method.

What issues does this PR fix or reference?

No issue, I tested in isolated environment.
Withing a week I will provide a blog article for a reference for env. setup.

@salt-jenkins

This comment has been minimized.

Show comment
Hide comment
@salt-jenkins

salt-jenkins Sep 17, 2017

Contributor

@epcim, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yagnik to be a potential reviewer.

Contributor

salt-jenkins commented Sep 17, 2017

@epcim, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yagnik to be a potential reviewer.

@yagnik

This comment has been minimized.

Show comment
Hide comment
@yagnik

yagnik Sep 17, 2017

Contributor

👍

Contributor

yagnik commented Sep 17, 2017

👍

@rallytime

This comment has been minimized.

Show comment
Hide comment
@rallytime

rallytime Sep 18, 2017

Contributor

Hi @epcim - This change has caused some tests to fail: https://jenkins.saltstack.com/job/PR/job/salt-pr-linode-ubuntu14-n/14795/

Can you take a look?

Contributor

rallytime commented Sep 18, 2017

Hi @epcim - This change has caused some tests to fail: https://jenkins.saltstack.com/job/PR/job/salt-pr-linode-ubuntu14-n/14795/

Can you take a look?

@epcim

This comment has been minimized.

Show comment
Hide comment
@epcim

epcim Sep 19, 2017

Contributor

Hmm. yep, that's the MOCKing.

Contributor

epcim commented Sep 19, 2017

Hmm. yep, that's the MOCKing.

epcim and others added some commits Sep 19, 2017

@cachedout cachedout merged commit 635da91 into saltstack:develop Sep 20, 2017

3 of 6 checks passed

default Build finished.
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #14873 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #2068 — FAILURE
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #17472 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #10218 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #14770 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment