New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

salt.cache.Cache() select correct item for default opt['cache'] #43619

Closed
wants to merge 1 commit into
base: 2017.7.2
from

Conversation

Projects
None yet
4 participants
@vernondcole
Contributor

vernondcole commented Sep 19, 2017

What does this PR do?

fix issue with salt.cache.Cache()

What issues does this PR fix or reference?

Issue #43599

Tests written?

No

vernoncole
@salt-jenkins

This comment has been minimized.

Show comment
Hide comment
@salt-jenkins

salt-jenkins Sep 19, 2017

Contributor

@vernondcole, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DmitryKuzmenko, @techhat and @rallytime to be potential reviewers.

Contributor

salt-jenkins commented Sep 19, 2017

@vernondcole, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DmitryKuzmenko, @techhat and @rallytime to be potential reviewers.

@vernondcole

This comment has been minimized.

Show comment
Hide comment
@vernondcole

vernondcole Sep 20, 2017

Contributor

The failing unit tests have nothing to do with this PR.

Contributor

vernondcole commented Sep 20, 2017

The failing unit tests have nothing to do with this PR.

@cachedout cachedout changed the base branch from 2017.7.2 to 2017.7 Sep 20, 2017

@cachedout cachedout changed the base branch from 2017.7 to 2017.7.2 Sep 20, 2017

@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Sep 20, 2017

Contributor

@vernondcole This fix is great but we need it submitted against 2017.7 instead of .2. We have a new branching strategy that allows us to better control and test fixes this way. I'll close this and if you could just re-open it against the correct branch we'll get it in. Thanks very much.

Contributor

cachedout commented Sep 20, 2017

@vernondcole This fix is great but we need it submitted against 2017.7 instead of .2. We have a new branching strategy that allows us to better control and test fixes this way. I'll close this and if you could just re-open it against the correct branch we'll get it in. Thanks very much.

@cachedout cachedout closed this Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment