New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vagrant and saltify cloud minor revisions #44415

Merged
merged 3 commits into from Nov 8, 2017

Conversation

Projects
None yet
4 participants
@vernondcole
Contributor

vernondcole commented Nov 6, 2017

What does this PR do?

This PR updates two different salt-cloud drivers, both of which are updates to my code. I hope that is okay.

  • Add a line to the vagrant cloud documentation stating that ssh_username is required when ssh_host is defined.

  • Adds an optimization to the saltify Wake-on-Lan option so that it attempts to ping the target machine before sending the wake-on-lan. This skips over the time that it would wait for the machine to boot up before deploying Salt to it. In other words: when re-deploying to a machine which is already running, do not wait for it to boot up.

  • Catches errors to give better user-friendly messages when ssh connections to Vagrant boxes do not work as expected (usually due to errors in the definitions).

What issues does this PR fix or reference?

None

Tests written?

No - existing tests do not cover these use cases.

Commits signed with GPG?

Yes

vernondcole added some commits Nov 2, 2017

@vernondcole

This comment has been minimized.

Show comment
Hide comment
@vernondcole

vernondcole Nov 7, 2017

Contributor

@garethgreenaway @cachedout Looks like the automatic mention bot is asleep. Would you be so kind as to review this PR?

Contributor

vernondcole commented Nov 7, 2017

@garethgreenaway @cachedout Looks like the automatic mention bot is asleep. Would you be so kind as to review this PR?

@rallytime rallytime requested a review from gtmanfred Nov 8, 2017

@rallytime rallytime merged commit 8e99aee into saltstack:develop Nov 8, 2017

7 of 9 checks passed

default Build finished.
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #3365 — FAILURE
Details
GPG All commits have a verified GPG signature
WIP ready for review
Details
codeclimate All good!
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #18923 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #11595 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #16309 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #16161 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment