-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance defaults.merge function. #44850
Enhance defaults.merge function. #44850
Conversation
@rallytime Akh, a typo 🤕 |
I also added an arg to don't copy in place, so it keeps the orig dicts untouched. |
…ults_merge_enhancements
@aabouzaid Looks like there are still a couple more lint errors. Would you mind taking care of those? |
@garethgreenaway Fixed :-) |
@aabouzaid Awesome! Thanks! Just waiting for automated tests to finish then we should be good to go. |
What does this PR do?
In
defaults.merge
function:merge_lists
option.in_place
option.Previous Behavior
Lists were not merged, and no unit test for
merge
function.New Behavior
Tests written?
Yes
Commits signed with GPG?
Not yet