Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if VALUE is a string_type #44965

Merged
merged 1 commit into from Jan 2, 2018
Merged

check if VALUE is a string_type #44965

merged 1 commit into from Jan 2, 2018

Conversation

@gtmanfred
Copy link
Contributor

gtmanfred commented Dec 13, 2017

What does this PR do?

key should always be a stringtype, we want to exclude booleans in the value.

What issues does this PR fix or reference?

Reported in the salt community slack
Thanks @robert-stojan

Commits signed with GPG?

Yes

key should always be a stringtype, we want to exclude booleans in the value.
@rallytime rallytime requested a review from isbm Dec 13, 2017
@rallytime

This comment has been minimized.

Copy link
Contributor

rallytime commented Dec 14, 2017

re-run lint

@rallytime rallytime requested a review from saltstack/team-suse Dec 27, 2017
@rallytime rallytime merged commit 3ab962b into saltstack:2016.11 Jan 2, 2018
6 of 7 checks passed
6 of 7 checks passed
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #14303 — FAILURE
Details
WIP ready for review
Details
default Build finished.
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #20277 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #12725 — SUCCESS
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #17657 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #17387 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.