ProfitBricks Cloud API v4 support

[edevenport]

What does this PR do?

Updates to support the ProfitBricks Cloud API v4:

• Support for the image aliases.
• Adding new location.

Expanding ProfitBricks cloud provider for a salt-cloud tool to support more commands:

• list-images
• list-locations
• create_datacenter
• Extended configuration with a delete_volume option.

Bug fixes:

• Server vmstate vs state response.

Documentation and test updates.

Tests written?

Yes

Commits signed with GPG?

No

[rallytime]

@tonybaloney Can you review this when you get a moment?

[gtmanfred]

What are the reasons we are forcing an upgrade to api v4. Is it still possible to use api v3, or have they shut it down completely?

Can we not manage both side by side based on which version of the library is installed?

[edevenport]

@gtmanfred - The ProfitBricks Cloud API v4 implements the much needed image_alias feature. Prior to v4, the image name or UUID was required which both change monthly for many ProfitBricks supplied images. This means the cloud profile can become invalid each month which can cause confusion for users.

Also, while the v3 API is still available, prior versions are not. It's not known when the v3 API will be deprecated. Forcing the currently supported v4 API will prevent this from becoming an issue.

[gtmanfred]

If it is still available i would rather not force it.

This is the same thing we did with rackspace, we supported their v1 api until they totally deprecated it, and ripped it out then.

[denza]

@gtmanfred We added compatibility check for the SDKs where the Profitbricks API 3 is used, like you suggested. This way a user will be informed about possible compatibility problem of a SDK he use. Could you please do a review.

[gtmanfred]

I left a few stylistic comments, other than that, it looks good! Thanks for making this compatible with the older version!

[denza]

@gtmanfred Sorry about that. Now we should be good to go.

[rallytime]

Thank you @edevenport! There are a handful of lint violations here: https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/17626/violations/file/salt/cloud/clouds/profitbricks.py/

Can you fix those? This also has a merge conflict as well. Can you resolve that as well?

[denza]

@rallytime violations are fixed. Conflict is resolved.

[rallytime]

Is there a reason you changed this reference from using ref to doc? We need to use ref here as using doc should no longer be done. This is failing the following test: https://jenkins.saltstack.com/job/PR/job/salt-pr-linode-ubuntu14-n/18095/testReport/junit/unit.test_doc/DocTestCase/test_check_for_doc_inline_markup/.

[denza]

@rallytime I made a fix you proposed for the test. Could you please review?