Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added salt-cloud support for ssh keys with Scaleway. #45089

Merged
merged 2 commits into from Dec 22, 2017

Conversation

jbadson
Copy link

@jbadson jbadson commented Dec 19, 2017

What does this PR do?

Modifies the clouds.scaleway module to support SSH keys for deploying salt to newly-created hosts. The key file location is specified in the config key "ssh_key_file" (similar to Digital Ocean).

What issues does this PR fix or reference?

None

Previous Behavior

The scaleway module only supported SSH with passwords.

New Behavior

SSH keys are now supported in addition to passwords.

Tests written?

No

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@rallytime
Copy link
Contributor

Hi @jbadson - welcome! Thank you for filing this PR. Can you fix the lint error defined here: https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/17507/violations/file/salt/cloud/clouds/scaleway.py/?

@jbadson
Copy link
Author

jbadson commented Dec 21, 2017

Apologies. Fix is pushed. I should have built a unit test for that.

@rallytime
Copy link
Contributor

re-run lint

@rallytime rallytime merged commit 90a928e into saltstack:develop Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants