Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added salt-cloud support for ssh keys with Scaleway. #45089

Merged
merged 2 commits into from Dec 22, 2017

Conversation

Projects
None yet
3 participants
@jbadson
Copy link

commented Dec 19, 2017

What does this PR do?

Modifies the clouds.scaleway module to support SSH keys for deploying salt to newly-created hosts. The key file location is specified in the config key "ssh_key_file" (similar to Digital Ocean).

What issues does this PR fix or reference?

None

Previous Behavior

The scaleway module only supported SSH with passwords.

New Behavior

SSH keys are now supported in addition to passwords.

Tests written?

No

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Dec 20, 2017

Hi @jbadson - welcome! Thank you for filing this PR. Can you fix the lint error defined here: https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/17507/violations/file/salt/cloud/clouds/scaleway.py/?

@rallytime rallytime requested a review from gtmanfred Dec 20, 2017

@jbadson

This comment has been minimized.

Copy link
Author

commented Dec 21, 2017

Apologies. Fix is pushed. I should have built a unit test for that.

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Dec 22, 2017

re-run lint

@rallytime rallytime merged commit 90a928e into saltstack:develop Dec 22, 2017

5 of 9 checks passed

jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #18029 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #5033 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #14592 — FAILURE
Details
default Build started sha1 is merged.
Details
WIP ready for review
Details
codeclimate All good!
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #20537 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #13008 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #17633 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.