Added salt-cloud support for ssh keys with Scaleway. #45089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @jbadson - welcome! Thank you for filing this PR. Can you fix the lint error defined here: https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/17507/violations/file/salt/cloud/clouds/scaleway.py/? |
Author
|
Apologies. Fix is pushed. I should have built a unit test for that. |
gtmanfred
approved these changes
Dec 22, 2017
Contributor
|
re-run lint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Modifies the clouds.scaleway module to support SSH keys for deploying salt to newly-created hosts. The key file location is specified in the config key "ssh_key_file" (similar to Digital Ocean).
What issues does this PR fix or reference?
None
Previous Behavior
The scaleway module only supported SSH with passwords.
New Behavior
SSH keys are now supported in addition to passwords.
Tests written?
No
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.