Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openbsdpkg.upgrade: implement pkg.upgrade for OpenBSD #45145

Merged
merged 1 commit into from Jan 9, 2018

Conversation

Projects
None yet
2 participants
@jasperla
Copy link
Contributor

commented Dec 22, 2017

What does this PR do?

This allows to upgrade all packages, a single package or a selection of packages

Previous Behavior

pkg.upgrade was not supported.

New Behavior

# salt salt.localdomain pkg.upgrade name=libsodium
salt.localdomain:
    ----------
    libsodium:
        ----------
        new:
            1.0.16p0
        old:
            1.0.15

Full upgrade including error reporting:

# salt salt.localdomain pkg.upgrade
salt.localdomain:
    ERROR: Problem encountered upgrading packages. Additional info follows:

    changes:
        ----------
        nghttp2:
            ----------
            new:
                1.28.0
            old:
                1.27.0
    result:
        ----------
        pid:
            23339
        retcode:
            1
        stderr:
            Can't install python-2.7.14p0 because of libraries
            |library util.13.0 not found
        stdout:
            quirks-2.402 signed on 2017-12-19T15:56:16Z
            | /usr/lib/libutil.so.12.2 (system): bad major
            Direct dependencies for python-2.7.14p0->2.7.14p0 resolve to sqlite3-3.21.0 gettext-0.19.8.1p1 libffi-3.2.1p2 bzip2-1.0.6p8
            Full dependency tree is gettext-0.19.8.1p1 libffi-3.2.1p2 sqlite3-3.21.0 bzip2-1.0.6p8 libiconv-1.14p3
            Couldn't find updates for python-2.7.14p0

Tests written?

No

Commits signed with GPG?

Yes

@jasperla jasperla force-pushed the jasperla:openbsdpkg/upgrade branch from 5088ab3 to 8cc106c Dec 28, 2017

@rallytime
Copy link
Contributor

left a comment

Thanks again @jasperla! I have one small comment here. This also needs some tests. :)

def upgrade_available(name):
'''
Check whether or not an upgrade is available for a given package

This comment has been minimized.

Copy link
@rallytime

rallytime Jan 2, 2018

Contributor

Can you add some .. versionadded:: Fluorine tags to this function and the new function below?

This comment has been minimized.

Copy link
@jasperla

jasperla Jan 2, 2018

Author Contributor

Sure thing!

@jasperla jasperla force-pushed the jasperla:openbsdpkg/upgrade branch 2 times, most recently from 1f84cbe to 237549d Jan 2, 2018

@jasperla

This comment has been minimized.

Copy link
Contributor Author

commented Jan 2, 2018

And now with patches too, though the coverage of openbsdpkg.py is currently a bit lacking. I'll submit a new PR later to improve the tests.

@jasperla jasperla force-pushed the jasperla:openbsdpkg/upgrade branch 2 times, most recently from e8e97a0 to 09789fd Jan 9, 2018

openbsdpkg.upgrade: implement pkg.upgrade for OpenBSD
this allows to upgrade all packages, a single package or a selection of packages

@jasperla jasperla force-pushed the jasperla:openbsdpkg/upgrade branch from 09789fd to 2a5c10c Jan 9, 2018

@jasperla

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2018

@rallytime this is good to go now?

@rallytime rallytime merged commit 96113c0 into saltstack:develop Jan 9, 2018

4 of 9 checks passed

codeclimate 2 issues to fix
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #18507 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #5512 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #15065 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #21011 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #13469 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #18067 — SUCCESS
Details
@jasperla

This comment has been minimized.

Copy link
Contributor Author

commented Jan 10, 2018

Thanks @rallytime !

@jasperla jasperla deleted the jasperla:openbsdpkg/upgrade branch Jan 10, 2018

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2018

@jasperla Of course! Thanks again for all of these great fixes and additions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.