Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Allow the onlyif & unless requisites in a state file. #45229

Conversation

Projects
None yet
3 participants
@garethgreenaway
Copy link
Member

commented Jan 2, 2018

What does this PR do?

Updates to state.py to allow the onlyif & unless requisites to both work when specified in a state file.

What issues does this PR fix or reference?

#30161

Previous Behavior

If both onlyif & unless were specified in a state file the unless requisites was ignored and only the onlyif requisites was used.

New Behavior

This change allows both to be used in a single state.

Tests written?

Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

garethgreenaway added some commits Jan 2, 2018

@garethgreenaway garethgreenaway force-pushed the garethgreenaway:30161_using_unless_onlyif_together branch from 4c4a158 to f4a6bfd Jan 2, 2018

@rallytime rallytime requested a review from thatch45 Jan 2, 2018

garethgreenaway and others added some commits Jan 4, 2018

@rallytime rallytime merged commit 9cb6ac3 into saltstack:develop Jan 8, 2018

4 of 9 checks passed

jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #5462 — ABORTED
Details
codeclimate 2 issues to fix
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #18457 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #15015 — FAILURE
Details
default Build started sha1 is merged.
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #20958 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #13421 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #18020 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.