Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acme challenge type #45414

Merged
merged 4 commits into from Jan 23, 2018
Merged

Acme challenge type #45414

merged 4 commits into from Jan 23, 2018

Conversation

@github-abcde
Copy link
Contributor

@github-abcde github-abcde commented Jan 12, 2018

What does this PR do?

Add parameters to be passed to the acme client:

  • preferred_challenges
  • tls_sni_01_port
  • tls_sni_01_address
  • http_01_port
  • http_01_address
    Improves debugging when requesting a certificate goes wrong by also returning the contents of stdout instead of stderr only.

What issues does this PR fix or reference?

None that I'm aware of.

New Behavior

The parameters mentioned above will be passed to the acme client (translated) if supplied.

Tests written?

No

Commits signed with GPG?

Yes

herbert.buurman and others added 3 commits Jan 12, 2018
Added parameters: preferred_challenges, tls_sni_01_port, tls_sni_01_address, http_01_port, http_01_address.
Always pass "--agree-tos" to client.
Also report stdout when things fail (instead of only stderr).
@rallytime rallytime merged commit 298aa6e into saltstack:develop Jan 23, 2018
3 of 10 checks passed
@github-abcde github-abcde deleted the acme_challenge_type branch Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants