Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acme challenge type #45414

Merged
merged 4 commits into from Jan 23, 2018

Conversation

Projects
None yet
2 participants
@github-abcde
Copy link
Contributor

commented Jan 12, 2018

What does this PR do?

Add parameters to be passed to the acme client:

  • preferred_challenges
  • tls_sni_01_port
  • tls_sni_01_address
  • http_01_port
  • http_01_address
    Improves debugging when requesting a certificate goes wrong by also returning the contents of stdout instead of stderr only.

What issues does this PR fix or reference?

None that I'm aware of.

New Behavior

The parameters mentioned above will be passed to the acme client (translated) if supplied.

Tests written?

No

Commits signed with GPG?

Yes

herbert.buurman and others added some commits Jan 12, 2018

salt/states/acme.py, salt/modules/acme.py:
Added parameters: preferred_challenges, tls_sni_01_port, tls_sni_01_address, http_01_port, http_01_address.
Always pass "--agree-tos" to client.
Also report stdout when things fail (instead of only stderr).

@rallytime rallytime merged commit 298aa6e into saltstack:develop Jan 23, 2018

3 of 10 checks passed

jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #19198 — ABORTED
Details
codeclimate 3 issues to fix
Details
default Build finished.
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #13992 — FAILURE
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #1617 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #6170 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #15636 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #21609 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #18599 — SUCCESS
Details

@github-abcde github-abcde deleted the ogd-software:acme_challenge_type branch Jan 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.