Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_pkg: pkg.refresh_db report an issue if a sls pkg definition does not contain a dict instead of aborting #45493

Conversation

@damon-atkins
Copy link
Member

damon-atkins commented Jan 17, 2018

What does this PR do?

What issues does this PR fix or reference?

#45432 pkg definition contained a string instead of a dict, which caused the pkg.refresh_db to abort with an unhanded exception.

Previous Behavior

Aborted with an unhanded exception.

New Behavior

Reports the issue, and continue. i.e. "Compiled contents, not a dictionary/hash"

salt win10test pkg.refresh_db

win10test:
    ERROR: Error occurred while generating repo db. Additional info follows:

    failed:
        2
    failed_list:
        ----------
        bad-file.sls:
            - Compiled contents, not a dictionary/hash
        dvscheduler2.sls:
            - package 'dvschedulerX', version number 1 is not a string
            - package 'dvschedulerX', version number 2 is not a string
    success:
        240
    total:
        242

Tests written?

No

Commits signed with GPG?

No

…instead of aborting.
@damon-atkins damon-atkins changed the title pkg.refresh_db report an issue if a sls pkg definition id not a dict instead of aborting pkg.refresh_db report an issue if a sls pkg definition does not contain a dict instead of aborting Jan 17, 2018
@damon-atkins damon-atkins changed the title pkg.refresh_db report an issue if a sls pkg definition does not contain a dict instead of aborting win_pkg: pkg.refresh_db report an issue if a sls pkg definition does not contain a dict instead of aborting Jan 17, 2018
@damon-atkins

This comment has been minimized.

Copy link
Member Author

damon-atkins commented Jan 17, 2018

@twangboy ready for review.

@rallytime rallytime merged commit ebd4db6 into saltstack:2016.11.9 Jan 17, 2018
4 of 9 checks passed
4 of 9 checks passed
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #18861 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #5861 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #15350 — FAILURE
Details
default Build started sha1 is merged.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #1355 — RUNNING
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #21306 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #13726 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #18330 — SUCCESS
Details
@damon-atkins

This comment has been minimized.

Copy link
Member Author

damon-atkins commented Jan 19, 2018

@rallytime @Ch3LL this is still outstanding against 2017.7.3 & oxygen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.