Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/adelcast/opkg restartcheck support #45554

Merged

Conversation

Projects
None yet
3 participants
@adelcast
Copy link
Contributor

commented Jan 19, 2018

What does this PR do?

Add NILinuxRT support for the checkrestart module. As part of this PR, I added NILinuxRT support for the service module too, as it is used by the restart module. I also fixed the ps grain definition for NILinuxRT (used by status.pid, which is used in the service module).

Tests written?

Yes. Enabled existing service module tests for NILinuxRT.

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

adelcast added some commits Jan 17, 2018

grains/core.py: provide correct ps parameters for NILinuxRT
The NILinuxRT distribution family uses busybox ps, which doesn't support
the -H option.

Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>
modules/debian_service.py: add NILinuxRT support
The NILinuxRT family uses the systemv init system. The module works
as-is.

Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>
modules/restartcheck.py: add NILinuxRT support
Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>
@cachedout
Copy link
Collaborator

left a comment

LGTM

@rallytime rallytime merged commit 502c597 into saltstack:develop Jan 20, 2018

5 of 10 checks passed

jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #19007 — ABORTED
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #15461 — ABORTED
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #1449 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #5984 — FAILURE
Details
WIP ready for review
Details
codeclimate All good!
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #21433 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #13827 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #18434 — SUCCESS
Details

@adelcast adelcast deleted the adelcast:dev/adelcast/opkg_restartcheck_support branch Jan 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.