Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/adelcast/opkg restartcheck support #45554

Merged

Conversation

adelcast
Copy link
Contributor

What does this PR do?

Add NILinuxRT support for the checkrestart module. As part of this PR, I added NILinuxRT support for the service module too, as it is used by the restart module. I also fixed the ps grain definition for NILinuxRT (used by status.pid, which is used in the service module).

Tests written?

Yes. Enabled existing service module tests for NILinuxRT.

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

The NILinuxRT distribution family uses busybox ps, which doesn't support
the -H option.

Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>
The NILinuxRT family uses the systemv init system. The module works
as-is.

Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>
Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>
Copy link
Contributor

@cachedout cachedout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rallytime rallytime merged commit 502c597 into saltstack:develop Jan 20, 2018
@adelcast adelcast deleted the dev/adelcast/opkg_restartcheck_support branch January 21, 2018 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants