Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add execution module for OpenBSD Packet Filter #45905

Merged
merged 1 commit into from
Feb 23, 2018

Conversation

jasperla
Copy link
Contributor

@jasperla jasperla commented Feb 7, 2018

What does this PR do?

Add a new module used to interact with the OpenBSD Packet Filter (pf). While it's possible to use pfctl on other platforms (e.g. FreeBSD or macOS) I have not yet verified it's working there.

What issues does this PR fix or reference?

#33248

Tests written?

Yes

Commits signed with GPG?

Yes

Copy link
Contributor

@rallytime rallytime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jasperla - I have one small request on this :)

.. versionadded:: Fluorine
'''

from __future__ import absolute_import
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Py2/Py3 compatibility, we need this line to be:

from __future__ import absolute_import, print_function, unicode_literals

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing; I've just pushed the fix.

# -*- coding: utf-8 -*-

# Import Python libs
from __future__ import absolute_import
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here as well.

@jasperla
Copy link
Contributor Author

@rallytime this should be good to go now, right?

@rallytime rallytime merged commit 8aaac01 into saltstack:develop Feb 23, 2018
@jasperla jasperla deleted the pf branch February 25, 2018 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants