add execution module for OpenBSD Packet Filter#45905
Merged
rallytime merged 1 commit intosaltstack:developfrom Feb 23, 2018
Merged
add execution module for OpenBSD Packet Filter#45905rallytime merged 1 commit intosaltstack:developfrom
rallytime merged 1 commit intosaltstack:developfrom
Conversation
jasperla
force-pushed
the
pf
branch
4 times, most recently
from
e9ca52b to
7c4dd4c
Compare
garethgreenaway
approved these changes
Feb 13, 2018
rallytime
suggested changes
Feb 15, 2018
salt/modules/pf.py
Outdated
Contributor
There was a problem hiding this comment.
For Py2/Py3 compatibility, we need this line to be:
from __future__ import absolute_import, print_function, unicode_literals
Contributor
Author
There was a problem hiding this comment.
Sure thing; I've just pushed the fix.
tests/unit/modules/test_pf.py
Outdated
Contributor
There was a problem hiding this comment.
Same comment here as well.
Contributor
Author
|
@rallytime this should be good to go now, right? |
rallytime
approved these changes
Feb 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a new module used to interact with the OpenBSD Packet Filter (pf). While it's possible to use pfctl on other platforms (e.g. FreeBSD or macOS) I have not yet verified it's working there.
What issues does this PR fix or reference?
#33248
Tests written?
Yes
Commits signed with GPG?
Yes