Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add execution module for OpenBSD Packet Filter #45905

Merged
merged 1 commit into from Feb 23, 2018

Conversation

Projects
None yet
3 participants
@jasperla
Copy link
Contributor

commented Feb 7, 2018

What does this PR do?

Add a new module used to interact with the OpenBSD Packet Filter (pf). While it's possible to use pfctl on other platforms (e.g. FreeBSD or macOS) I have not yet verified it's working there.

What issues does this PR fix or reference?

#33248

Tests written?

Yes

Commits signed with GPG?

Yes

@jasperla jasperla force-pushed the jasperla:pf branch from 41d8a1c to b4d95c4 Feb 7, 2018

@jasperla jasperla force-pushed the jasperla:pf branch 4 times, most recently from e9ca52b to 7c4dd4c Feb 7, 2018

@rallytime rallytime requested a review from garethgreenaway Feb 8, 2018

@jasperla jasperla force-pushed the jasperla:pf branch from 7c4dd4c to 5f224bc Feb 8, 2018

@rallytime
Copy link
Contributor

left a comment

Thanks @jasperla - I have one small request on this :)

.. versionadded:: Fluorine
'''

from __future__ import absolute_import

This comment has been minimized.

Copy link
@rallytime

rallytime Feb 15, 2018

Contributor

For Py2/Py3 compatibility, we need this line to be:

from __future__ import absolute_import, print_function, unicode_literals

This comment has been minimized.

Copy link
@jasperla

jasperla Feb 17, 2018

Author Contributor

Sure thing; I've just pushed the fix.

# -*- coding: utf-8 -*-

# Import Python libs
from __future__ import absolute_import

This comment has been minimized.

Copy link
@rallytime

rallytime Feb 15, 2018

Contributor

Same comment here as well.

@jasperla jasperla force-pushed the jasperla:pf branch from 5f224bc to 01f99e5 Feb 17, 2018

@jasperla jasperla force-pushed the jasperla:pf branch from 01f99e5 to a973b70 Feb 22, 2018

@jasperla

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2018

@rallytime this should be good to go now, right?

@rallytime rallytime merged commit 8aaac01 into saltstack:develop Feb 23, 2018

4 of 10 checks passed

jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #2495 — ABORTED
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #16547 — ABORTED
Details
codeclimate 10 issues to fix
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #20141 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #7057 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #22538 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #14885 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #19494 — SUCCESS
Details

@jasperla jasperla deleted the jasperla:pf branch Feb 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.