Skip to content

Add module for Pure Storage FlashBlade array #45993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rallytime merged 1 commit into from
Feb 26, 2018
Merged

Add module for Pure Storage FlashBlade array #45993

rallytime merged 1 commit into from
Feb 26, 2018

Conversation

@sdodsley
Copy link
Contributor

@sdodsley sdodsley commented Feb 12, 2018 •
edited
Loading

What does this PR do?

Provides ability to manage filesystems and snapshots on Pure Storage FlashBlade external storage arrays

Tests written?

Yes

Commits signed with GPG?

No

@sdodsley sdodsley force-pushed the purefb_module branch 3 times, most recently from d162dba to fd4f14b Compare February 13, 2018 01:51
rallytime
rallytime suggested changes Feb 15, 2018
View reviewed changes
Copy link
Contributor

@rallytime rallytime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdodsley This looks great. Thanks for submitting this. I have some requested changes, mostly for getting this to match salt-style.

If you could also add some unit tests for this new module, that would be fantastic.

salt/modules/purefb.py Outdated
Copy link
Contributor

@rallytime rallytime Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated to Fluorine :)

Copy link
Contributor

@rallytime rallytime Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some other references to Oxygen in this file as well, but those should all be Fluorine. If you could update those, too, that'd be great!

salt/modules/purefb.py Outdated
Copy link
Contributor

@rallytime rallytime Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove these global variables here (VERSION and USER_AGENT_BASE)? I don't see these used any where in this file.

salt/modules/purefb.py Outdated
Copy link
Contributor

@rallytime rallytime Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you expand this out to all separate lines? I know that's picky, but Salt style is to not have docs on one line like this.

salt/modules/purefb.py Outdated
Copy link
Contributor

@rallytime rallytime Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here about one-line docs. Can you also change these double quotes to single quotes? Salt style calls for single quoted doc-strings, rather than double quotes.

salt/modules/purefb.py Outdated
Copy link
Contributor

@rallytime rallytime Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here ;)

salt/modules/purefb.py Outdated
Copy link
Contributor

@rallytime rallytime Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be a lot easier to read with .format() here.

salt/modules/purefb.py Outdated
Copy link
Contributor

@rallytime rallytime Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is --> if

salt/modules/purefb.py Outdated
Copy link
Contributor

@rallytime rallytime Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of __utils__ 👍

@rallytime rallytime added the needs-testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Feb 15, 2018
@sdodsley sdodsley changed the title Add module for Pure Storage FlashBlade array WIP - Add module for Pure Storage FlashBlade array Feb 15, 2018
@sdodsley sdodsley changed the title WIP - Add module for Pure Storage FlashBlade array Add module for Pure Storage FlashBlade array Feb 22, 2018
@sdodsley
Copy link
Contributor Author

sdodsley commented Feb 23, 2018

GO GO Jenkins!

@sdodsley
Copy link
Contributor Author

sdodsley commented Feb 23, 2018

@rallytime will this do? Why are all checks failing????

@rallytime
Copy link
Contributor

rallytime commented Feb 24, 2018

Thanks for adding those tests @sdodsley! Yeah, those test failures are unrelated. We are working on getting those fixed up. However, there are some related lint failures: https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/19496/violations/file/tests/unit/modules/test_purefb.py/

Can you fix those?

@rallytime rallytime removed the needs-testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Feb 24, 2018
@sdodsley
Copy link
Contributor Author

sdodsley commented Feb 24, 2018

@rallytime fixed the lint failures. Sorry about that - they got lost in the noise of the other failures 😊

@rallytime rallytime merged commit 87ba05c into saltstack:develop Feb 26, 2018
@sdodsley
Copy link
Contributor Author

sdodsley commented Mar 16, 2018

@rallytime can you force a rerun of the webpage creation for the develop execution modules documentation so this module becomes visible

@rallytime
Copy link
Contributor

rallytime commented Mar 16, 2018

@sdodsley I should have caught this in the review, but you'll need to add some doc directives for sphinx to pick this up and build it automatically in the docs. Can you add a PR for this?

See the examples in doc/ref/modules/all/* for how to do this. A file for the new module is needed as well as an entry in the index.rst file.

@sdodsley sdodsley deleted the purefb_module branch March 17, 2018 00:59
@sdodsley sdodsley mentioned this pull request Mar 17, 2018
Merged
@sdodsley
Copy link
Contributor Author

sdodsley commented Mar 17, 2018

@rallytime PR #46590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rallytime rallytime rallytime approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sdodsley @rallytime