Skip to content

Conversation

@The-Loeki
Copy link
Contributor

@The-Loeki The-Loeki commented Feb 25, 2018

What does this PR do?

Fix various issues with the dns utils, expand it's functionality and increase it's testing coverage

New Behavior

  • Add TLSA, CAA and SSHFP 'intelligent' records
  • Various bugs and corner cases fixed
  • remove duplicate code and functions
  • add solid TLD determination when available

Previous PR's

#39639
#40269

Tests written?

Yes

@garethgreenaway
Copy link
Contributor

garethgreenaway commented Feb 26, 2018

@The-Loeki Looks like some of the DNS tests are failing.

@The-Loeki
Copy link
Contributor Author

The-Loeki commented Mar 8, 2018

@garethgreenaway / @terminalmage
I'd like to ask you guys to merge this if that's OK; I've got the equivalent replacement module WIP as well pending that.

I'd like your opinion before continuing as well:
I've noticed for 2018.3 the refresh_dns() and dns_check() functions got moved to salt.utils.network
That IMHO isn't that logical considering salt.utils.dns.etcetera()

So:

  • could you care less?

  • or make salt.utils.network.dns and refactor the lot into that

  • or refactor dns_check() & refresh_dns() to salt.utils.dns.check()|refresh_resolv(()

  • and/or make salt.utils(.network).dns a directory to move more stuff into in expectation of future development

@terminalmage
Copy link
Contributor

I'm not familiar enough with this DNS utils module to comment on it at the moment.

@terminalmage terminalmage removed their request for review March 9, 2018 18:38
@garethgreenaway
Copy link
Contributor

@The-Loeki Probably makes more sense and more consistent to move all dns related utils into salt.utils.dns

@rallytime rallytime merged commit ebe7fd4 into saltstack:develop Apr 30, 2018

def sshfp_rec(rdata):
'''
Validate and parse DNS record data for TLSA record(s)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be sshfp record(s)

@The-Loeki The-Loeki deleted the dns-impr branch April 27, 2019 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants