-
Notifications
You must be signed in to change notification settings - Fork 5.6k
DNS utils improvements #46184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNS utils improvements #46184
Conversation
|
@The-Loeki Looks like some of the DNS tests are failing. |
|
@garethgreenaway / @terminalmage I'd like your opinion before continuing as well: So:
|
|
I'm not familiar enough with this DNS utils module to comment on it at the moment. |
|
@The-Loeki Probably makes more sense and more consistent to move all dns related utils into salt.utils.dns |
|
|
||
| def sshfp_rec(rdata): | ||
| ''' | ||
| Validate and parse DNS record data for TLSA record(s) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be sshfp record(s)
What does this PR do?
Fix various issues with the dns utils, expand it's functionality and increase it's testing coverage
New Behavior
Previous PR's
#39639
#40269
Tests written?
Yes