Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Additional Azure ARM Modules #46186

Merged

Conversation

Projects
None yet
3 participants
@nicholasmhughes
Copy link
Contributor

commented Feb 25, 2018

What does this PR do?

This PR adds execution and state modules for manipulating compute infrastructure (resource groups, virtual networks, etc.) in the Azure Resource Manager cloud environment. Additionally, it adds the ability to connect instances to availability sets and load balancer backend pools in the cloud module. Finally, it fixes some small bugs in the cloud module, most notably the ability to resize the OS disk when using managed disks. Required Azure module versions were also updated in the documentation.

What issues does this PR fix or reference?

N/A

Tests written?

No

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

nicholasmhughes added some commits Feb 25, 2018

@salt-jenkins salt-jenkins requested a review from saltstack/team-cloud Feb 25, 2018

nicholasmhughes added some commits Feb 26, 2018

@gtmanfred

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2018

This is great!

Thanks!
Daniel

@rallytime rallytime merged commit 5f88d64 into saltstack:develop Mar 2, 2018

4 of 10 checks passed

codeclimate 371 issues to fix
Details
default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #2675 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #20324 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #7238 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #16726 — FAILURE
Details
WIP ready for review
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #22726 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #15063 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #19675 — SUCCESS
Details

@nicholasmhughes nicholasmhughes deleted the nicholasmhughes:add-additional-azurearm-modules branch Mar 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.