Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
adding loaded feature to mac_service #46206
What does this PR do?
Adds the ability for the mac_service module to recognize whether or not a mac service should have an active PID when checking the status, as some macOS services run on intervals or are initiated by other manners. This improves the support for the service state which previously would only work properly for services that are set be always running with an active PID.
What issues does this PR fix or reference?
service.status on macOS would return an empty string for any service that did not have an active PID. Which would send a false positive of sorts to the service state module.
Salt will now check the macOS service to see whether or not the service should actively be running by checking the
CC @gtmanfred as we briefly talked about this addition.
Commits signed with GPG?
Welcome @weswhet! Thank you for this change.
Looks like there is a lint error on this: https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/19595/violations/file/salt/modules/mac_service.py/
Can you fix that up?