adding loaded feature to mac_service #46206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtmanfred
approved these changes
Feb 27, 2018
Contributor
|
Welcome @weswhet! Thank you for this change. Looks like there is a lint error on this: https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/19595/violations/file/salt/modules/mac_service.py/ Can you fix that up? |
Contributor
Author
|
Thanks for the warm welcome @rallytime, lint check is passing now. Let me know if I need to do anything else. 😄 |
rallytime
reviewed
Mar 2, 2018
salt/modules/mac_service.py
Outdated
| :rtype: bool | ||
| .. versionadded:: |
Contributor
There was a problem hiding this comment.
Oops, this line should be .. versionadded:: Fluorine
Contributor
Author
There was a problem hiding this comment.
whoops, looks like you beat me to it. Thanks
rallytime
approved these changes
Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the ability for the mac_service module to recognize whether or not a mac service should have an active PID when checking the status, as some macOS services run on intervals or are initiated by other manners. This improves the support for the service state which previously would only work properly for services that are set be always running with an active PID.
What issues does this PR fix or reference?
None
Previous Behavior
service.status on macOS would return an empty string for any service that did not have an active PID. Which would send a false positive of sorts to the service state module.
New Behavior
Salt will now check the macOS service to see whether or not the service should actively be running by checking the
KeepAlivekey in service plist. If the service is not meant to be always running but the service is properly loaded in launchd service.status will now return a string 'loaded'.CC @gtmanfred as we briefly talked about this addition.
Tests written?
No
Commits signed with GPG?
Yes